Update static-module #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goto-bus-stop any progress on this PR? |
Member
Author
|
sorry, i forgot about it. i got a bit stuck on the test failure :/ |
Member
|
@goto-bus-stop could you fix the tests? |
Member
Author
|
Yep I'll put it on my agenda again. This one is a bit tough to fix, because static-eval returns undefined when it fails but also when the node actually evaluates to undefined. So when evaluating the arguments to path.join we can't just bail out whenever we see undefined.
Just writing that out made me think of a possible fix inside static-module tho!
…On 18 January 2018 01:46:00 CET, Steve Mao ***@***.***> wrote:
Assigned #83 to @goto-bus-stop.
--
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub:
#83 (comment)
--
Sent from mobile. Please excuse my brevity.
|
goto-bus-stop
added a commit
to browserify/static-module
that referenced
this pull request
Jan 20, 2018
This will just not replace expressions that cannot be evaluated because of a runtime error. This is needed for browserify/brfs#83 which fixes browserify/brfs#81.
Member
Author
|
browserify/static-module#39 should do it! |
goto-bus-stop
added a commit
to browserify/static-module
that referenced
this pull request
Jan 30, 2018
This will just not replace expressions that cannot be evaluated because of a runtime error. This is needed for browserify/brfs#83 which fixes browserify/brfs#81.
goto-bus-stop
force-pushed
the
new-static-module
branch
from
3e13cb7 to
a15f36a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://nodesecurity.io/advisories/548