Skip to content

don't require experimental: true for iframes #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanmcguire12 merged 2 commits into from
Jul 27, 2025
Merged

don't require experimental: true for iframes #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9070aa9
allow iframes when experimental is undefined or false
seanmcguire12 Jul 24, 2025
4d5ae09
changeset
seanmcguire12 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-games-trade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@browserbasehq/stagehand": patch
---

move iframe out of 'experimental'
12 changes: 0 additions & 12 deletions lib/StagehandPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import {
HandlerNotInitializedError,
StagehandDefaultError,
ExperimentalApiConflictError,
ExperimentalNotConfiguredError,
} from "../types/stagehandErrors";
import { StagehandAPIError } from "@/types/stagehandApiErrors";
import { scriptContent } from "@/lib/dom/build/scriptContent";
Expand Down Expand Up @@ -621,9 +620,6 @@ ${scriptContent} \
// If actionOrOptions is an ObserveResult, we call actFromObserveResult.
// We need to ensure there is both a selector and a method in the ObserveResult.
if (typeof actionOrOptions === "object" && actionOrOptions !== null) {
if ("iframes" in actionOrOptions && !this.stagehand.experimental) {
throw new ExperimentalNotConfiguredError("iframes");
}
// If it has selector AND method => treat as ObserveResult
if ("selector" in actionOrOptions && "method" in actionOrOptions) {
const observeResult = actionOrOptions as ObserveResult;
Expand Down Expand Up @@ -754,10 +750,6 @@ ${scriptContent} \
iframes,
} = options;

if (iframes !== undefined && !this.stagehand.experimental) {
throw new ExperimentalNotConfiguredError("iframes");
}

if (this.api) {
const result = await this.api.extract<T>(options);
this.stagehand.addToHistory("extract", instructionOrOptions, result);
Expand Down Expand Up @@ -861,10 +853,6 @@ ${scriptContent} \
iframes,
} = options;

if (iframes !== undefined && !this.stagehand.experimental) {
throw new ExperimentalNotConfiguredError("iframes");
}

if (this.api) {
const result = await this.api.observe(options);
this.stagehand.addToHistory("observe", instructionOrOptions, result);
Expand Down