Skip to content

[chore] rm old fillInVariables fn #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

[chore] rm old fillInVariables fn #706

merged 2 commits into from
Apr 25, 2025

Conversation

seanmcguire12
Copy link
Member

why

  • remove dead code

what changed

  • remove unused fillInVariables function

test plan

  • regression evals

Copy link

changeset-bot bot commented Apr 25, 2025

🦋 Changeset detected

Latest commit: 80fca5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@browserbasehq/stagehand Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Removed unused fillInVariables function from lib/inference.ts which previously handled variable placeholder replacement using <|VARIABLE|> syntax.

  • Removed dead code function fillInVariables from lib/inference.ts that was no longer being used in the codebase
  • Regression tests recommended to verify no functionality breaks from removal
  • Function originally handled replacing <|VARIABLE|> placeholders with user values but appears to be obsolete

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@seanmcguire12 seanmcguire12 merged commit 18ac6fb into main Apr 25, 2025
13 checks passed
@github-actions github-actions bot mentioned this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants