-
Notifications
You must be signed in to change notification settings - Fork 983
support scrolling #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support scrolling #563
Conversation
🦋 Changeset detectedLatest commit: c63bb73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tested and confirmed scrolling with
|
yeah its not supposed to work if |
lib/handlers/actHandler.ts
Outdated
@@ -448,6 +449,78 @@ export class StagehandActHandler { | |||
|
|||
throw new PlaywrightCommandException(e.message); | |||
} | |||
} else if (method === "scrollTo" || method === "scroll") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the llm calling scroll by pixel. If anything by % or maybe like we had in chunking something like 'scroll down'. It would be interesting to add some sort of feedback loop like 'successfully scrolled all the way to the bottom' so the agent doesn't get stuck. It seems performPlaywrightMethod doesn't return anything?
why
what changed
performPlaywrightMethod
example usage