Merged
Conversation
filip-michalsky
commented
Jun 12, 2025
filip-michalsky
commented
Jun 12, 2025
filip-michalsky
commented
Jun 12, 2025
filip-michalsky
commented
Jun 12, 2025
filip-michalsky
commented
Jun 12, 2025
filip-michalsky
commented
Jun 13, 2025
i# Please enter a commit message to explain why this merge is necessary, merge main
Collaborator
|
can we add a description ☝️ |
miguelg719
reviewed
Jul 31, 2025
miguelg719
reviewed
Jul 31, 2025
Collaborator
There was a problem hiding this comment.
this test doesn't seem to do much
Collaborator
Author
There was a problem hiding this comment.
agree, just checking URL nav is what is expected is not super helpful regression test -removed
miguelg719
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
We would like to understand if basic functionality of stagehand works as expected by running regression tests in CI. this works against bb-hosted pages (should be static) and testing expected behaviour of stagehand. The set of the regression tests is not as robust as in TS, but its a start.
what changed
Added a suite of regression tests.
test plan
CI passes.