Merged
Conversation
stagehand/sync/context.py
Outdated
|
|
||
| from playwright.sync_api import BrowserContext, Page | ||
|
|
||
| from .page import SyncStagehandPage |
Collaborator
There was a problem hiding this comment.
what is this? thought we do only async?
Collaborator
Author
There was a problem hiding this comment.
I think this got back from a merge conflict issue
filip-michalsky
requested changes
May 31, 2025
Collaborator
filip-michalsky
left a comment
filip-michalsky
left a comment
There was a problem hiding this comment.
pls update init logic to only load server url if executing remotely
remove sync context stuff?
filip-michalsky
approved these changes
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no need for base since it's only 1 implementation. Couple of minor fixes along. Placeholder
browser.pyto move all browser-connection functionality to, andapi.pyto separate all client stuff. eventually renaming client->main