Conversation
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="examples/pydoll_tab_example.py">
<violation number="1" location="examples/pydoll_tab_example.py:9">
P3: Duplicate docstring line with typo: `ePage.getFrameTree` should be removed. This line duplicates line 8 and contains an error (missing backtick, extra 'e').</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| - Attach Pydoll to the same browser via CDP (`cdp_url`) | ||
| - Use Pydoll to navigate | ||
| - Fetch the current page's `frame_id` via CDP `Page.getFrameTree` | ||
| - Fetch the current page's `frame_id` via CDP ePage.getFrameTree` |
There was a problem hiding this comment.
P3: Duplicate docstring line with typo: ePage.getFrameTree should be removed. This line duplicates line 8 and contains an error (missing backtick, extra 'e').
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At examples/pydoll_tab_example.py, line 9:
<comment>Duplicate docstring line with typo: `ePage.getFrameTree` should be removed. This line duplicates line 8 and contains an error (missing backtick, extra 'e').</comment>
<file context>
@@ -0,0 +1,207 @@
+- Attach Pydoll to the same browser via CDP (`cdp_url`)
+- Use Pydoll to navigate
+- Fetch the current page's `frame_id` via CDP `Page.getFrameTree`
+- Fetch the current page's `frame_id` via CDP ePage.getFrameTree`
+- Pass `frame_id` into `session.observe/act/extract`
+
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just the example file - no helpers / custom code added.
Summary by cubic
Adds an example script that connects Pydoll to a Browserbase-backed Stagehand session over CDP, retrieves the current page’s frame_id, and uses it with observe and extract. This helps users run Pydoll and Stagehand in the same tab.
Written for commit 346276a. Summary will update on new commits.