Fixing downloads behavior for use_api=false#183
Merged
miguelg719 merged 6 commits intomainfrom Aug 19, 2025
Merged
Conversation
Contributor
Author
|
This isn't yet tested! |
miguelg719
reviewed
Aug 19, 2025
Collaborator
|
A changeset would be great! try |
Contributor
Author
Tested now, works for this config! |
miguelg719
approved these changes
Aug 19, 2025
Merged
Collaborator
|
closes #130 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
Downloads were not working properly in use_api=false mode when using Playwright with CDP (Chrome DevTools Protocol). The browser's default download behavior was not configured, causing downloads to fail or be blocked. This change adds proper CDP configuration to enable downloads, matching the behavior already implemented in the TypeScript version of Stagehand.
what changed