csv-parser library updates #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have a sendRpc target (like VScode) we can try to fill in the fs library to some extent. We won't be able to get full coverage because we can't do synchronous RPCs (so e.g. filelib won't work transparently) But we can do a lot of it, and we can probably update the pyret-lang files to use a reasonable subset that we can polyfill with RPCs to embedding contexts that do have a filesystem
|
This is the idea of this + brownplt/pyret-lang#1769
|
jpolitz
commented
Jan 24, 2025
| var fsWrapper = { | ||
| fs: { | ||
| readFile: async function(path, opts, callback) { | ||
| debugger; |
| @@ -337,7 +337,7 @@ libpyret: | |||
|
|
|||
| $(BUNDLED_DEPS): src/scripts/npm-dependencies.js | |||
| # Explicitly exclude crypto, buffer, and stylus, nested npm dependencies that aren't needed | |||
| if(!window.MESSAGES.sendRpc) { throw new Error("Cannot readFile on the web"); } | ||
| else { | ||
| try { | ||
| const result = await window.MESSAGES.sendRpc('fs', 'readFileSync', [path]); |
There was a problem hiding this comment.
Should also do stuff with opts here to get back the utf8 string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.