Skip to content

[WIP] Share modal updates #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

asolove
Copy link
Contributor

@asolove asolove commented Nov 7, 2023

@schanzer
Copy link

@asolove any chance we can close this out in the near future? It's super low-hanging fruit..

@asolove
Copy link
Contributor Author

asolove commented Jan 11, 2024 via email

@schanzer
Copy link

Excuse my ignorance here - where are these questions?

@asolove
Copy link
Contributor Author

asolove commented Jan 13, 2024

Oh, sorry, there is a long discussion in another issue around further updates to the share sheet. But yeah, this small round of tweaks can just get merged shortly.

@schanzer
Copy link

Does this PR address all three checkboxes, above? Or just the one? If it's just one I think it's best to wait until we snag the others.

@jpolitz jpolitz merged commit 3638775 into brownplt:horizon Feb 18, 2025
@jpolitz
Copy link
Member

jpolitz commented Feb 18, 2025

This makes things better and it looks like the comments say “just get this much in”, so merging. Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants