horizon -> mainmast #433
Merged
horizon -> mainmast #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll specify these in more detail in the future PR. - Line-plot-methods: curved, line width, trendlines (5 Methods), lineDashStyle: [2, 2], pointshapes, labels, image-labels, selection mode (ChartWindow), - curved does not work with render-charts but does with render-chart - Scatter-plot-methods: labels, image-labels, point-size, pointshapes, selection mode (ChartWindow), - Pie-chart-methods: Explode, colors, 3D, Donut, Rotate, Collapse Threshold - Donut is ignored if also 3D - Histogram-methods: labels
For now I’ll just keep the commit to a cleaner outline of the new methods, documentation and detailed Pull Request coming soon… Also see notes and bugs below: New methods: Global Chart Window methods: - Background methods: [background-color] - Border methods: [border-size, border-color] Plot Chart Window methods: - Major Gridlines: [gridlines-minspacing, gridlines-color] - Minor Gridlines: [show-minor-gridlines, minor-gridlines-minspacing, minor-gridlines-color] - Selection Mode: [select-multiple] Line-Plot-Series: - Line methods: [curved, line-width, dashed-line, dashline-style] - Trendline methods: [trendline-type, trendline-color, trendline-width, trendline-opacity] - Point methods: [point-shape, labels, image-labels] Scatter-Plot-Series: - Point methods: [point-shape, labels, image-labels, point-size] Pie-Chart-Series: - methods: [Explode, colors, 3D, Donut, Rotate, Collapse Threshold] Histogram-Series: - methods: [labels, colors] Box-plot-Series - Methods: [colors] Notes: btoa is Depreciating. Tried to use buffer library as recommended but unsure how to import it. Ended up using a fix from Stack overflow to take care of illegal Latin1 characters (happened when adding trendlines). Bugs: curved does not work with render-charts but does with render-chart Donut is ignored if also 3D More to come after testing finishes in testing commit coming soon!
- Added basic edge case checking and better type-checking for previous methods - Fixed Image points in scatter and line plot series
- Fixed point shape dent to use the correct apothem formula - Extended trendline methods to work with scatter-plot-series
…yret.org into JohnUUU-stacked-bar-chart Merge and add new test for line images as well as scatter images [2] vs. [1] indexing for the SVG seems to work OK with both of these versions (which do not show legends by default)
… will allow include of charts to be more future-proof
…t the kind of temporary that lasts 3 years) workaround for insert/picker permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge over remaining grouped bar chart, etc, changes