Potential fix for code scanning alert no. 9: Clear-text logging of sensitive information #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/brokle-ai/brokle-python/security/code-scanning/9
To resolve this issue, we need to ensure that API keys (even partial) are never included in log messages. The fix should replace any value for
api_keyin the context info dictionary with a static placeholder such as"<hidden>"or simply omit the field from the dictionary returned byget_info(). This change needs to happen inbrokle/observability/context.pyinside theObservabilityContext.get_info()method. By ensuring thatapi_keyis never shown, downstream code (likescripts/final_validation.py) will never leak even partial keys in logs.No changes are required in the logging or reporting functions themselves; the root is the info exposed via
get_info/get_context_info.Suggested fixes powered by Copilot Autofix. Review carefully before merging.