Remove protocol to resolve to https automatically from the browser#165
Open
heryxpc wants to merge 1 commit intobroccolini:masterfrom
Open
Remove protocol to resolve to https automatically from the browser#165heryxpc wants to merge 1 commit intobroccolini:masterfrom
heryxpc wants to merge 1 commit intobroccolini:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR the styles won't load if serving via HTTPS when loading URL from site.github.url
We are using this template at https://github.com/JConfMexico/jalapenio/blob/cbc700b1d3fe285a761510c5fae7036aafaa22bf/_config.yml#L15
Noticed that the CSS styles break after we enable HTTPS to Github Pages. This is a common mixed content error documented by Github.
This appears to be a common issue on Github pages when using the scriptlet
default: site.github.url. Applied the general pattern discussed there to allow the browser to self-resolve the protocol.