Skip to content

Stable 1.x#15

Closed
stefanpenner wants to merge 2 commits intomasterfrom
stable-1.x
Closed

Stable 1.x#15
stefanpenner wants to merge 2 commits intomasterfrom
stable-1.x

Conversation

@stefanpenner
Copy link
Contributor

@stefanpenner stefanpenner commented Aug 5, 2016

I've created a 1.x stable branch, so that we can re-publish 1.2.1 without tmp and with the files whitelist.

This PR exists as a way to make sure me and @joliss sync up, and are both aware of this.

cc @joliss

Turbo87 and others added 2 commits August 5, 2016 08:59
This prevents "tmp/" from ending up on NPM again inside the package
@stefanpenner
Copy link
Contributor Author

Ah, also apparently I cannot publish. @joliss can give me publish on npm?

@joliss
Copy link
Member

joliss commented Aug 27, 2016

Thanks! The master branch is still compatible, so we don't need a separate stable-1.x branch. I've rebased this on master and released 1.2.2, and updated the v1.2.2 tag with my rebase as well.

I've added you on npm to broccoli-plugin, and broccoli-source as well.

I generally prefer .npmignore over package.json by the way, since if we add another module in the future we might forget to update the "files" field and push a broken distribution. I've pushed fdce2ab to that effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants