Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-1678] When monitoring source load tags, match prefix instead of exact match. #614

Merged
merged 7 commits into from
Jul 19, 2022
Merged

[GH-1678] When monitoring source load tags, match prefix instead of exact match. #614

merged 7 commits into from
Jul 19, 2022

Conversation

tbl3rd
Copy link
Contributor

@tbl3rd tbl3rd commented Jul 14, 2022 •
edited
Loading

Purpose

Changes

  • Factor out retry filter keys.
  • Rename terra-executor-workflows-sql-params to filter-query-for-unretried-workflows.
  • Privatize some "public for testing" vars.
  • Prefix match loadTag with LIKE on snapshot queries.
  • Document changes.

Review Instructions

  • Start with datarepo.clj and staged-source.md.
  • Scan the rest while ignoring whitespace changes.

@tbl3rd tbl3rd marked this pull request as ready for review July 15, 2022 20:11
@tbl3rd tbl3rd self-assigned this Jul 15, 2022
nmalfroy
nmalfroy approved these changes Jul 19, 2022
View reviewed changes
Copy link

@nmalfroy nmalfroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ok? I'm sorta guessing at a lot of this clojure syntax

@tbl3rd tbl3rd merged commit 7847ca6 into develop Jul 19, 2022
tbl3rd added a commit that referenced this pull request Jul 19, 2022
@tbl3rd
Release 0.19.0 (#615)
c2b4438 
* [GH-1678] When monitoring source load tags, match prefix instead of exact match.  (#614)
* Update version and CHANGELOG. Still need to find the test restore PR.
* Add test restore PR.
@tbl3rd tbl3rd deleted the tbl/GH-1678-load-tag-hack branch September 30, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmalfroy nmalfroy nmalfroy approved these changes

@okotsopoulos okotsopoulos Awaiting requested review from okotsopoulos

@aednichols aednichols Awaiting requested review from aednichols

Assignees

@tbl3rd tbl3rd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbl3rd @nmalfroy