[GH-1433] No TDR temporary snapshots in tests #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, we can rely on temporary datasets which automatically delete any of their snapshots before the dataset.
okotsopoulos
commented
Mar 24, 2022
| @@ -193,18 +193,6 @@ | |||
| datarepo/delete-snapshots-then-dataset | |||
There was a problem hiding this comment.
Here's where we clean up any snapshots as part of cleaning up a temporary dataset.
tbl3rd
approved these changes
Mar 24, 2022
| (util/bracket | ||
| #(datarepo/create-snapshot snapshot-request) | ||
| datarepo/delete-snapshot | ||
| f)) |
okotsopoulos
added a commit
that referenced
this pull request
Apr 1, 2022
GH-1623 workloads/update-workload! should define own transactions (#597) GH-1640 Broken Terra Submission links in completed workflow Slack messages (#598) GH-1639 Pin jinja2 version for mkdocks compatibility (#596) GH-1433 No TDR temporary snapshots in tests (#595) GH-1619 Add workload info to sink logs (#594) GH-1638 Disable link unfurling when Slacking watchers (#593)
okotsopoulos
added a commit
that referenced
this pull request
Apr 4, 2022
GH-1623 workloads/update-workload! should define own transactions (#597) GH-1640 Broken Terra Submission links in completed workflow Slack messages (#598) GH-1639 Pin jinja2 version for mkdocks compatibility (#596) GH-1433 No TDR temporary snapshots in tests (#595) GH-1619 Add workload info to sink logs (#594) GH-1638 Disable link unfurling when Slacking watchers (#593)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Previous work in this space: #561
I found this new improvement in my "stash graveyard".
In integration tests which interact with TDR, we don't actually have to create temporary snapshots within temporary datasets (and cross our fingers that developers won't use temporary snapshots within fixed datasets). You might remember that deleting a snapshot obtains an exclusive lock on the underlying dataset, which lead to flapping test failures on concurrent runs.
Instead, we can create snapshots as normal within temporary datasets: temporary datasets automatically delete any of their snapshots before the dataset.