-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-1604] Add error handling to Slack service #584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfl.integration.slack-test/test-send-notification is passing locally but failing in GitHub Actions: 403 - Vault API error - permission denied
Populated by Atlantis from Vault path
okotsopoulos
commented
Feb 25, 2022
tbl3rd
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still poking around, but not sure when I'll get back to it.
okotsopoulos
added a commit
that referenced
this pull request
Mar 4, 2022
GH-1629 TerraExecutor gets method configuration version from Firecloud (#585) GH-1553 GH-1604 Add error handling to Slack service (#584) GH-1628 Look at the first 7 workloads returned in test-workflows-by-filters. (#583) GH-1617 Consistent workload representation for logs (#579) GH-1624 Rename covid -> staged in code, docs (#580)
okotsopoulos
added a commit
that referenced
this pull request
Mar 7, 2022
GH-1629 TerraExecutor gets method configuration version from Firecloud (#585) GH-1553 GH-1604 Add error handling to Slack service (#584) GH-1628 Look at the first 7 workloads returned in test-workflows-by-filters. (#583) GH-1617 Consistent workload representation for logs (#579) GH-1624 Rename covid -> staged in code, docs (#580)
okotsopoulos
added a commit
that referenced
this pull request
Mar 7, 2022
GH-1629 TerraExecutor gets method configuration version from Firecloud (#585) GH-1553 GH-1604 Add error handling to Slack service (#584) GH-1628 Look at the first 7 workloads returned in test-workflows-by-filters. (#583) GH-1617 Consistent workload representation for logs (#579) GH-1624 Rename covid -> staged in code, docs (#580)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The Slack token is stored in Vault. We now read it into environment variable
WFL_SLACK_TOKEN
.Atlantis syncs the value from Vault into GitHub Secrets, and we use it to set the environment variable as needed within GitHub Actions: https://github.com/broadinstitute/terraform-ap-deployments/pull/554
Updated documentation.
Catch throwables within
slack
service, and add unit test.System Tests
Start a local server with Slack notifications enabled:
Run system test known to emit Slack message off of local server:
Resulting Slack message, and test passes:
Then ran the full suite, all pass:
Review Instructions