GH-1578 TerraDataRepoSource filters old rows before reducing #560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses an edge case bug when
TerraDataRepoSource
polls for new rows to snapshot.The desired behavior: if a snapshot creation job fails, we should automatically reconsider its rows for snapshotting until they are snapshotted successfully or they age out of our 2 hour check window.
Bug: if a workload's first snapshot creation job fails, we did not reconsider its rows for snapshotting.
Fix: filter old snapshot creation job rows by status prior to reducing to a single object with all old row IDs. This filtration previously took place within the reduction, but If you pass a singleton sequence to
reduce
it is returned as it's passed in. https://clojuredocs.org/clojure.core/reduce