Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1448: Exceptions fail to be logged as JSON. #531

Merged
merged 8 commits into from
Nov 5, 2021

Conversation

tbl3rd
Copy link
Contributor

@tbl3rd tbl3rd commented Nov 4, 2021

Purpose

Changes

  • Hack how JSONWriter handles Throwables.

Review Instructions

@tbl3rd tbl3rd marked this pull request as ready for review November 5, 2021 19:59
Copy link
Contributor

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fun review. Thank you.

@tbl3rd tbl3rd merged commit ba1ab84 into develop Nov 5, 2021
okotsopoulos added a commit that referenced this pull request Nov 18, 2021
- [GH-1475] Update test inputs buckets ([#538](#538))

- [GH-1529] Bump WFL develop version to 0.10.0 ([#537](#537))

- [GH-1474] [GH-1475] [GH-1494] TDR Sink Changes ([#520](#520))

- [GH-1522] TerraWorkspaceSink: identifier can be a workflow input ([#534](#534))

- [GH-1515] WFL-created TDR snapshots include table in name ([#536](#536))

- [GH-1463] WFL API retry by status also requires submission id ([#525](#525))

- [GH-1473] Update GitHub Pages with new Swagger access ([#516](#516))

- [GH-1448] Exceptions fail to be logged as JSON. ([#531](#531))

- [GH-1472] Merge main into develop ([#533](#533))

- [GH-1517] Add automated test for updating method configurations with mismatched versions ([#528](#528))

- [GH-1517] Log instead of throw on TerraExecutor method config version mismatch ([#527](#527))

Co-authored-by: Tom Lyons <tbl@broadinstitute.org>
Co-authored-by: rfricke-asymmetrik <75337761+rfricke-asymmetrik@users.noreply.github.com>
okotsopoulos added a commit that referenced this pull request Nov 30, 2021
- [GH-1475] Update test inputs buckets ([#538](#538))

- [GH-1529] Bump WFL develop version to 0.10.0 ([#537](#537))

- [GH-1474] [GH-1475] [GH-1494] TDR Sink Changes ([#520](#520))

- [GH-1522] TerraWorkspaceSink: identifier can be a workflow input ([#534](#534))

- [GH-1515] WFL-created TDR snapshots include table in name ([#536](#536))

- [GH-1463] WFL API retry by status also requires submission id ([#525](#525))

- [GH-1473] Update GitHub Pages with new Swagger access ([#516](#516))

- [GH-1448] Exceptions fail to be logged as JSON. ([#531](#531))

- [GH-1472] Merge main into develop ([#533](#533))

- [GH-1517] Add automated test for updating method configurations with mismatched versions ([#528](#528))

- [GH-1517] Log instead of throw on TerraExecutor method config version mismatch ([#527](#527))

Co-authored-by: Tom Lyons <tbl@broadinstitute.org>
Co-authored-by: rfricke-asymmetrik <75337761+rfricke-asymmetrik@users.noreply.github.com>
@tbl3rd tbl3rd deleted the tbl/GH-1448-exception-json branch December 9, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants