Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WFL deployment. #526

Merged
merged 62 commits into from
Nov 3, 2021
Merged

Fix WFL deployment. #526

merged 62 commits into from
Nov 3, 2021

Conversation

tbl3rd
Copy link
Contributor

@tbl3rd tbl3rd commented Oct 18, 2021

Purpose

With the removal of the ui component, the swagger page was no longer working. This required changes to the configmap to adjust the reverse proxy to allow the swagger code in WFL to display it. In finding that solution, we also found that the swagger page could no longer allow the user to authenticate using the Authorize button. There were some missing components that the swagger page relied on to make this work.

We also found in testing swagger that there were some workloads with old values in the watchers column that would cause the api/workloads endpoint fail to return workloads.

More info provided with related issues in: #530

Related tickets:
https://broadinstitute.atlassian.net/browse/GH-1472
https://broadinstitute.atlassian.net/browse/GH-1505
https://broadinstitute.atlassian.net/browse/GH-1520

Changes

  • Updated appVersion, helm chart version and wfl version
  • Made changes to the helm ConfigMap to accommodate swagger being served by the api
  • Liquibase changelog added to clean up watchers column in the database
  • Missing files required by swagger were added to the api container

Review Instructions

  • Run locally and open swagger
  • Hit Authorize and you should be able to just click Authorize again and be good to go
  • Once successful, hit the api/v1/workloads endpoint to make sure that results are shown and no errors occur

@rfricke-asymmetrik rfricke-asymmetrik marked this pull request as ready for review November 3, 2021 15:33
Copy link
Contributor

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd like the PR description to include ticket link(s) and a summary of the issues / corresponding fixes. Thank you!

@rfricke-asymmetrik rfricke-asymmetrik merged commit a8e9638 into main Nov 3, 2021
@tbl3rd tbl3rd deleted the tbl/nothing-works branch December 9, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants