-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WFL deployment. #526
Merged
Merged
Fix WFL deployment. #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9c1fc07.
okotsopoulos
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'd like the PR description to include ticket link(s) and a summary of the issues / corresponding fixes. Thank you!
rfricke-asymmetrik
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
With the removal of the ui component, the swagger page was no longer working. This required changes to the configmap to adjust the reverse proxy to allow the swagger code in WFL to display it. In finding that solution, we also found that the swagger page could no longer allow the user to authenticate using the
Authorize
button. There were some missing components that the swagger page relied on to make this work.We also found in testing swagger that there were some workloads with old values in the watchers column that would cause the
api/workloads
endpoint fail to return workloads.More info provided with related issues in: #530
Related tickets:
https://broadinstitute.atlassian.net/browse/GH-1472
https://broadinstitute.atlassian.net/browse/GH-1505
https://broadinstitute.atlassian.net/browse/GH-1520
Changes
Review Instructions
api/v1/workloads
endpoint to make sure that results are shown and no errors occur