GH-1163: Support Somatic Genomes in production. #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbl3rd
force-pushed
the
tbl/GH-1163-prod-clio-url
branch
3 times, most recently
from
c699cbf
to
3b9a650
Compare
tbl3rd
force-pushed
the
tbl/GH-1163-prod-clio-url
branch
from
b0768d3
to
335eeac
Compare
ehigham
reviewed
Feb 19, 2021
api/src/wfl/auth.clj
Outdated
| [] | ||
| (-> (service-account-credentials) .refreshAccessToken .getTokenValue)) | ||
| (some-> (service-account-credentials) .refreshAccessToken .getTokenValue)) |
There was a problem hiding this comment.
Why some->? If we can't find any service account credentials then we're kind of stuffed? Why not error here instead of getting a 403 later?
There was a problem hiding this comment.
OK. Was propagating from above.
makerules/modules.mk
Outdated
Comment on lines
29
to
33
| INTEGRATION := $(DERIVED_MODULE_DIR)/integration.$(TIMESTAMP) | ||
| LINT := $(DERIVED_MODULE_DIR)/lint.$(TIMESTAMP) | ||
| PREBUILD := $(DERIVED_MODULE_DIR)/prebuild.$(TIMESTAMP) | ||
| SYSTEM := $(DERIVED_MODULE_DIR)/system.$(TIMESTAMP) | ||
| UNIT := $(DERIVED_MODULE_DIR)/unit.$(TIMESTAMP) |
There was a problem hiding this comment.
These were previously sorted in order of execution?
There was a problem hiding this comment.
Execution order is determined by dependence, but OK.
ehigham
approved these changes
Feb 19, 2021
rexwangcc
approved these changes
Feb 19, 2021
| "gs://broad-gotc-dev-wfl-sg-test-inputs/pipeline/G96830/NA12878/v23/NA12878.cram"}}], | ||
| :creator (:email @endpoints/userinfo)}) | ||
| "gs://broad-gotc-dev-wfl-sg-test-inputs/pipeline/G96830/NA12878/v23/NA12878.cram"}}] | ||
| :creator "@workloads/email"}) ; quoted to avoid log spam |
|
Thank you for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
Review Instructions