Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-1125] Don't finish unstarted workloads #296

Merged
merged 3 commits into from
Jan 8, 2021
Merged

[GH-1125] Don't finish unstarted workloads #296

merged 3 commits into from
Jan 8, 2021

Conversation

jack-r-warren
Copy link
Contributor

Purpose

Changes

  • Make the SQL query for unfinished workflows also include workflows with no status, so we correctly leave such workflows untouched if we create and then call update on it
  • Make all the module integration tests catch this error

Review Instructions

  • Integration tests check this via Ed's reproduction steps

@jack-r-warren jack-r-warren merged commit fd3bfe8 into main Jan 8, 2021
@jack-r-warren jack-r-warren deleted the jack-r-warren/GH-1125-proper-update branch January 8, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehigham ehigham ehigham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jack-r-warren @ehigham