Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-1115] Update directory docs for wfl batching #292

Merged
merged 4 commits into from
Jan 7, 2021
Merged

[GH-1115] Update directory docs for wfl batching #292

merged 4 commits into from
Jan 7, 2021

Conversation

rexwangcc
Copy link
Contributor

Purpose

Changes

  • Update the docs based on guidelines from the ticket.

Review Instructions

  • No instructions.

@rexwangcc rexwangcc marked this pull request as ready for review January 7, 2021 16:02
ehigham
ehigham approved these changes Jan 7, 2021
View reviewed changes
docs/md/modules-directory-usage.md Outdated Show resolved Hide resolved
jack-r-warren
jack-r-warren approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@jack-r-warren jack-r-warren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Suppose we'll find out if there's some other bottleneck in the shell script

@rexwangcc rexwangcc merged commit 48fa62f into main Jan 7, 2021
@rexwangcc rexwangcc deleted the rex/GH-1115-update-directory-docs-for-wfl-batching branch January 7, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-r-warren jack-r-warren jack-r-warren approved these changes

@ehigham ehigham ehigham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rexwangcc @ehigham @jack-r-warren