Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-1111] Handle environments in AOU file paths #282

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

samanehsan
Copy link
Contributor

Purpose

https://broadinstitute.atlassian.net/browse/GH-1111

Changes

  • Change the env parameter to accept "staging" in addition to "dev" and "prod".
  • Only cleanup files in the input bucket from the env directory. For example, running the script with the "staging" environment will clean up files in the staging directory of the dev-aou-arrays-input bucket. This is required because dev and staging could have samples with the same exact chip name, chip well barcode and analysis version.
  • Add "staging" environment to keep_files.

Review Instructions

  • No instructions.

Set the "prefix" when listing files
in a bucket to the environment
Copy link
Contributor

@tbl3rd tbl3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the overlap of dev and staging won't confuse things more.

@samanehsan
Copy link
Contributor Author

samanehsan commented Dec 14, 2020

I realized since the script leaves behind the "latest" analysis version, it will need to handle both the old and new file paths...fixing this now! Actually it'll probably be easier to update the old file paths instead of making the script more complicated.

@samanehsan samanehsan merged commit 950e19b into main Dec 14, 2020
@rhiananthony rhiananthony deleted the se-update-aou-cleanup-script branch March 17, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants