[GH-1061] don't send back defaults when user specifies reference_fasta_prefix #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexwangcc
approved these changes
Nov 13, 2020
tbl3rd
approved these changes
Nov 13, 2020
| (let [hg38 "gs://gcp-public-data--broad-references/hg38/v0/"] | ||
| (merge references/contamination-sites | ||
| (references/hg38-genome-references prefix) | ||
| (references/hg38-genome-references nil) |
There was a problem hiding this comment.
Could we (def hg38-genome-references …) and just merge it as data?
The idea is that I think it's weird to specify all references via a reference_fasta_prefix - surely that should only define the reference fasta? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Using the reference_fasta_prefix to dictate all the references is weird. We should only use it to compute the reference_fasta.
Changes