Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-1022] make wgs use CromwellWorkflow table. #204

Merged
merged 3 commits into from
Oct 30, 2020

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Oct 29, 2020

Purpose

In this change, I'm making the wgs workload store its workflow data in the new (repurposed) CromwellWorkflow table .
I've implemented the loader such that it's backwards compatible with our current deployments- we can load old WGS workflows as well as new ones (added tests).

The only issue is that I need to bump the version without creating a release in order for the tests to pass in github.

I'm pretty sure that wgs now accepts input_bams as well as input_crams now. I'll add a test to verify this.

Copy link
Contributor

@rexwangcc rexwangcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ehigham ehigham force-pushed the ehigham/GH-1022-wgs-workload branch from f472e2a to 63a93aa Compare October 30, 2020 15:50
@ehigham ehigham force-pushed the ehigham/GH-1022-wgs-workload branch from 63a93aa to c46dccd Compare October 30, 2020 15:54
@ehigham ehigham merged commit 3f0a124 into master Oct 30, 2020
@ehigham ehigham deleted the ehigham/GH-1022-wgs-workload branch October 30, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants