[GH-1035] Add terra module to WFL #197
Conversation
samanehsan
changed the title
api/src/wfl/service/terra.clj
Outdated
| (defn get-submission | ||
| "Get information about a Terra Cromwell submission." | ||
| [terra-url workspace-namespace workspace-name submission-id] | ||
| (let [workspace-url (workspace-api-url terra-url workspace-namespace workspace-name)] |
There was a problem hiding this comment.
Why not call http/get directly?
There was a problem hiding this comment.
I think there's some slight benefit to making the code here the same as that for create-submission. If there's a http/post we can call there then sure I guess but this is pretty readable to me as-is.
There was a problem hiding this comment.
No particular reason...I referenced another module when writing this one and it used http/request but I think http/get is a bit clearer!
There was a problem hiding this comment.
Oh I didn't see Jack's comment until I refreshed. I updated these functions to use http/get and http/post so let me know if you all think this is more readable!
@rexwangcc I just added the wfl service account to the Terra workspace and the test passes now! I also added the rest of the Hornet team. |
|
|
||
| (deftest test-terra-submission | ||
| (testing "A workflow is created for the entity" | ||
| (let [submission-id (terra/create-submission terra-url workspace-namespace workspace-name |
There was a problem hiding this comment.
Thanks for adding the test. Makes it easier to see how it's meant to be used.
What's the difference between the namespace and the name? Does it make sense to combine these into a fully-qualified name? Thinking this would simplify the call site for both the workspace and the method configuration?
There was a problem hiding this comment.
The workspace-namespace corresponds to a gcloud billing project and can contain multiple workspaces. Here's one I set up in dev using the "general-dev-billing-account" namespace: https://bvdp-saturn-dev.appspot.com/#workspaces. I like the idea of combining the two parameters into one since they're just used in the submission url.
There was a problem hiding this comment.
Also it seems like the method-configuration-namespace will always be the same as the workspace-namespace. But they can be specified individually through the Terra API so I'm assuming there's a case where they can be different.
Purpose
Started as a part of https://broadinstitute.atlassian.net/browse/GH-1018
Changes
A submission is like Terra's concept of a workload. It includes what data need to get processed with what pipeline and when you make a request to get a submission it includes a list of the workflows that were started in Cromwell.
Review Instructions