Skip to content

Conversation

@bistline
Copy link
Contributor

BACKGROUND & CHANGES

This fixes another issue with using graceful_auto_reconnect when processing DotPlotGene documents. The issue was that the parent function using this decorator did not have the same signature as the insert_many method in IngestPipeline, leading it to use the wrong value for sourcing the original documents from the insert. Now, DotPlotGenes#load and IngestPipeline#insert_many have the same number of arguments, allowing the reconnect function to work properly.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.03%. Comparing base (449ef27) to head (86c9682).
⚠️ Report is 3 commits behind head on development.

Files with missing lines Patch % Lines
ingest/dot_plot_genes.py 60.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #410      +/-   ##
===============================================
+ Coverage        77.94%   78.03%   +0.09%     
===============================================
  Files               31       31              
  Lines             4642     4643       +1     
===============================================
+ Hits              3618     3623       +5     
+ Misses            1024     1020       -4     
Files with missing lines Coverage Δ
ingest/expression_writer.py 90.90% <ø> (ø)
ingest/dot_plot_genes.py 97.63% <60.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bistline bistline requested a review from eweitz December 15, 2025 15:51
@bistline bistline marked this pull request as ready for review December 15, 2025 15:51
@bistline bistline merged commit dd972d5 into development Dec 15, 2025
8 checks passed
@bistline bistline deleted the jb-dot-plot-reconnect-bugfix branch December 15, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants