This repository was archived by the owner on Mar 21, 2025. It is now read-only.
DR-2291 Add a new front end configuration chart #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to create a k8s resource for configuring an SSL policy for things like prometheus and grafana using an annotation on the ingress config like: `networking.gke.io/v1beta1.FrontendConfig: "<what we specify in the sslPolicy value>"` Note: the default ssl policy is set to one that we create in Terraform that enforces that TLS 1.2 is used by the client
nmalfroy
force-pushed
the
dr-2291-nm-add-front-end-config-chart
branch
from
e5ba921 to
e230a80
Compare
samanehsan
approved these changes
Dec 2, 2021
tlangs
approved these changes
Dec 2, 2021
Contributor
tlangs
left a comment
tlangs
left a comment
There was a problem hiding this comment.
Approved, but with extremely minor comments.
| sslPolicy: {{ .Values.sslPolicy }} | ||
| redirectToHttps: | ||
| enabled: true | ||
| responseCodeName: MOVED_PERMANENTLY_DEFAULT No newline at end of file |
| @@ -0,0 +1,2 @@ | |||
| --- | |||
| sslPolicy: global-ssl-policy | |||
pshapiro4broad
approved these changes
Dec 2, 2021
| .svn/ | ||
| # Common backup files | ||
| *.swp | ||
| *.bak |
Contributor
Author
There was a problem hiding this comment.
lol...yeah...some copy pasta
nmalfroy
force-pushed
the
dr-2291-nm-add-front-end-config-chart
branch
from
0f6e6fb to
3761431
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to create a k8s resource for configuring an SSL policy for things like prometheus and grafana using an annotation on the ingress config like:
networking.gke.io/v1beta1.FrontendConfig: "<what we specify in the sslPolicy value>"Note: the default ssl policy is set to one that we create in Terraform that enforces that TLS 1.2 is used by the client
Note: this also does http -> https redirects