DR 2291 Use front end config chart to add ssl policy to all prometheus and grafana endpoints #426
Conversation
| namespace: monitoring # target namespace | ||
| chart: datarepo-helm/frontend-config # chart name | ||
| version: 0.1.0 | ||
| missingFileHandler: Warn |
There was a problem hiding this comment.
Do we need to pass in the chart values here?
There was a problem hiding this comment.
I actually set the default to the right value so that we wouldn't have to
There was a problem hiding this comment.
(that's in the other repo)
There was a problem hiding this comment.
And the value is hardcoded in our Terraform:
https://github.com/broadinstitute/terraform-jade/blob/9f48597975045e0ce838807273e6e8127380ca4a/datarepo/modules/core-infrastructure/network.tf#L2
There was a problem hiding this comment.
Got it! What about the service account values? https://github.com/broadinstitute/datarepo-helm/pull/176/files#diff-8a0f72427127d2e4f48fb06370094a5bc83a1b9ad7f5fe682b591bef8c052743R58
There was a problem hiding this comment.
Ah, that's copy pasta. I'll remove
There was a problem hiding this comment.
k, removed from that other pr
No description provided.