WX-921 TES support #191
Merged
WX-921 TES support #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgainerdewar
force-pushed
the
jgd_WX-921_tes
branch
from
df9bd28 to
b584b21
Compare
MattMcL4475
reviewed
Feb 17, 2023
coa-helm/templates/tes.yaml
Outdated
| value: {{ .Values.tes.batchImagePublisher }} | ||
| - name: BatchImageOffer | ||
| value: {{ .Values.tes.batchImageOffer }} | ||
| - name: BatchImageSku |
MattMcL4475
reviewed
Feb 17, 2023
coa-helm/templates/tes.yaml
Outdated
| value: {{ .Values.tes.batchImageOffer }} | ||
| - name: BatchImageSku | ||
| value: {{ .Values.tes.batchImageSku | quote }} | ||
| - name: BatchImageVersion |
THWiseman
approved these changes
Feb 21, 2023
|
Going forward, you will want to track changes to https://github.com/microsoft/ga4gh-tes/tree/develop/src/deploy-tes-on-azure/scripts/helm as well as https://github.com/microsoft/ga4gh-tes/blob/develop/src/TesApi.Web/appsettings.json |
BMurri
reviewed
Feb 21, 2023
coa-helm/values.yaml
Outdated
| logLevel: Warning | ||
| # Currently this represents the max task processing time | ||
| sasTokenExpirationInSeconds: 86400 | ||
| retryPolicyOptions: |
There was a problem hiding this comment.
I'd recommend renaming this to simply retryPolicy
aednichols
approved these changes
Feb 21, 2023
Contributor
Author
|
@aednichols This should be ready for another look. |
aednichols
approved these changes
Feb 22, 2023
| system { | ||
| max-concurrent-workflows = 10000 | ||
| max-concurrent-workflows = 100 |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables workflow execution in the Azure app. Highlights:
This relies on in-progress Leo changes in IA-4017