-
Notifications
You must be signed in to change notification settings - Fork 378
AN-291 Remove Nvidia Tesla K80 GPU support #7583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
But don't use it yet
Honestly, no one should use default GPU, but whatever
| val NVIDIATeslaT4 = GpuType("nvidia-tesla-t4") | ||
|
|
||
| val DefaultGpuType: GpuType = NVIDIATeslaK80 | ||
| val DefaultGpuType: GpuType = NVIDIATeslaT4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to opinions on this default. T4 is the most modern GPU of the lot and the one I see used most often in practice.
I also think few people rely on the default GPU anyway, which is a good thing – because Google deleted the old default!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
T4 make sense. It would either be that or the V100 and the T4 is cheaper.
dspeck1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
It is silly to implement cost capping support for a GPU that's no longer usable since May 2024. Also addressed some ambiguities around GPUs in GCP Batch, since I was already in the right place in the code.
Update GCP Batch library to a version that supports the driver version fieldnvidiaDriverVersionfield, but Cromwell does not currently pass itSimilar to DataBiosphere/terra-ui#5167
nvidia-smioutput on Life Sciences:nvidia-smioutput on Batch:Release Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes