-
Notifications
You must be signed in to change notification settings - Fork 375
fixes #3201 #7469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fixes #3201 #7469
Conversation
aednichols
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that for most mainstream configurations, this change will have no effect.
It will enable certain niche use cases, but also risks breaking an unknown number of cases that work fine now.
All in all, I'm not sure the juice is worth the squeeze.
|
This is intended to make it more portable Currently, cromwell couldn't work on NixOS or Guix, for example, see #3201 |
|
For what it's worth, Cromwell unofficially "supports" (as in people use it and don't seem to have major issues) macOS, Ubuntu, and the RHEL family of OSes. |
|
This small change could make it portable on any esoteric distribution / container
Not using env is more "risky" in term of portability, as it would be less portable This is due to unix requirements |
|
Asking for reviews |
Description
fixes #3201
Release Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes