[WX-1361] Remove Confusing Error Message #7449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THWiseman
changed the title
aednichols
approved these changes
Jun 13, 2024
Collaborator
aednichols
left a comment
aednichols
left a comment
There was a problem hiding this comment.
Nice work finding a concise solution!
Co-authored-by: Adam Nichols <anichols@broadinstitute.org>
jgainerdewar
approved these changes
Jun 13, 2024
Collaborator
jgainerdewar
left a comment
jgainerdewar
left a comment
There was a problem hiding this comment.
Nice job finding such a small and tidy solution!
| returnCode: Option[Int] = None, | ||
| jobExecutionMap: JobExecutionMap = Map.empty | ||
| jobExecutionMap: JobExecutionMap = Map.empty, | ||
| omitFromWorkflowLevelFailures: Boolean = false |
Collaborator
There was a problem hiding this comment.
Nitpick that you can feel free to ignore if you disagree - IMO boolean arguments where true represents negation require readers to think too hard. I think it's easier to understand if it's includeInWorkflowLevelFailures: Boolean = true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Cromwell restarts during a failure, it must fail the 'next' upcoming tasks in order to cleanly terminate the workflow. During this process, it was logging an error that isn't really an error (and was very confusing to users).
This PR:
Release Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes