[WX-1283] Add Support for Intel Ice Lake and Sapphire Rapids CPUs #7250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aednichols
approved these changes
Nov 8, 2023
Collaborator
aednichols
left a comment
aednichols
left a comment
There was a problem hiding this comment.
LGTM 👍
Could use a CHANGELOG.md entry.
jgainerdewar
approved these changes
Nov 13, 2023
| case cpu if cpu > 8 && cpu <= 22 => c3Standard_22 | ||
| case cpu if cpu > 22 && cpu <= 44 => c3Standard_44 | ||
| case cpu if cpu > 44 && cpu <= 88 => c3Standard_88 | ||
| case cpu if cpu > 88 => c3Standard_176 |
Collaborator
There was a problem hiding this comment.
We check these case statements in order and will use the first one that matches, so in each one you can assume that all previous case checks didn't match. So if you want you can make this more like
case cpu if cpu <= 4 => c3Standard_4
case cpu if cpu <= 8 => c3Standard_8
case cpu if cpu <= 22 => c3Standard_22
...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for two more CPU types. Recommended reading: machine types.
Ice Lakewas very simple to support since it is a customizable N2 machine likeCascade Lakeis, and therefore can use identical logic.Sapphire Rapidswas slightly more involved since it is not customizable like the other machine types are. AddedPredefinedMachineType.scalato support this endeavor and leave room for future platforms.I ran some workflows with my local cromwell and confirmed that the VMs created in Google Cloud are appropriately provisioned. A centaur test should also confirm that this is working as expected.