Document a general-purpose recovery process #4991
Conversation
|
Now I see what's wrong with the playbook, no dot graphs |
| @@ -0,0 +1,18 @@ | |||
| # Documented Processes | |||
There was a problem hiding this comment.
how happy is the Markdown toolchain going to be with uppercase file extensions?
There was a problem hiding this comment.
Not sure which toolchain - or which extension - you mean. Do you have a specific downstream tool in mind?
| @@ -0,0 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| while IFS= read -r -d '' file | |||
There was a problem hiding this comment.
why not just
for dot in $(find . -name "*.dot" -print0)
do
...
done
There was a problem hiding this comment.
You can ask shellcheck why - it made me do it 😄
There was a problem hiding this comment.
hmm might be whitespace safe 🤔
There was a problem hiding this comment.
Yeah apparently this is for whitespace safety, TIL https://unix.stackexchange.com/questions/174016/how-do-i-use-null-bytes-in-bash
| while IFS= read -r -d '' file | ||
| do | ||
| echo "Rendering graph ${file} into ${file}.png" | ||
| dot -Tpng -o "$file.png" "$file" |
There was a problem hiding this comment.
To avoid blah.dot.png:
...
png="${dot%.dot}.png"
echo "Rendering graph ${dot} into ${png}"
...
There was a problem hiding this comment.
The .dot.png is preexisting so I'm reluctant to change that as well in this PR - could that happen as a follow up maybe?
| @@ -0,0 +1,18 @@ | |||
| # Documented Processes | |||
| @@ -0,0 +1,7 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| while IFS= read -r -d '' file | |||
There was a problem hiding this comment.
Yeah apparently this is for whitespace safety, TIL https://unix.stackexchange.com/questions/174016/how-do-i-use-null-bytes-in-bash
| while IFS= read -r -d '' file | ||
| do | ||
| echo "Rendering graph ${file} into ${file}.png" | ||
| dot -Tpng -o "$file.png" "$file" |
An attempt to document my observation of our general purpose debugging process - will hopefully help the next generation of Cromwell fire troubleshooters.
See the process rendered and in situ
NB: If this gets approval, I'll update our playbook to link to this as our "general purpose fallback process"