Call cache no copy fixups and centaur error improvements #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcovarr
approved these changes
May 8, 2019
| # No point retrying failures since they'll just end up colliding with previous results: | ||
| retryTestFailures: false | ||
|
|
||
|
|
| @@ -386,7 +398,6 @@ object Operations { | |||
| validateMetadata(workflow, expectedMetadata).handleErrorWith({ _ => | |||
| for { | |||
| _ <- IO.sleep(2.seconds) | |||
| _ = if (LogFailures) Console.err.println(s"Metadata mismatch for ${submittedWorkflow.id} - retrying") | |||
There was a problem hiding this comment.
this does get printed if it never reaches the expected value?
There was a problem hiding this comment.
Correct - the actual message (including which metadata was wrong) gets printed if this "eventuallyMetadata" times out
cjllanwarne
force-pushed
the
cjl_jes_call_cache_no_copy_take_2
branch
from
4d536f0 to
15c3a42
Compare
kshakir
reviewed
May 10, 2019
Co-Authored-By: kshakir <github@kshakir.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are side effects of my investigation into the
invalidate_bad_caches_jes_no_copytest on PAPIv1:
invalidate_bad_caches_jes_no_copybecause it will never work the second time (even on v2)Succeededto speed up the debug cycle