Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set initial state withdrawn wm hint (fixes #2046) #2056

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

heavyjoost
Copy link
Contributor

@heavyjoost heavyjoost commented Oct 9, 2024

Checklist

  • I have described the changes
  • I have linked to any relevant GitHub issues, if applicable
  • All new code is licensed under GPLv3

Description

This makes sure the initial state wmhit gets set to withdrawn. This is needed for Conky to run in a dock (aka slit in Fluxbox). I've used this for about a week now without issues in Openbox. Fixes #2046.

@github-actions github-actions bot added sources PR modifies project sources display: x11 Issue related to X11 backend labels Oct 9, 2024
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit a54aa14
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/670727dfa9b1cf0008f4020b

Copy link
Collaborator

@Caellian Caellian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why I commented this out. I looked at the blame and it was a (too) large refactor of many things, so it was either me not knowing that WithdrawnState must be initially set or forgetting to uncomment after debugging something. I apologize for missing this while testing.

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@Caellian Caellian merged commit ebef880 into brndnmtthws:main Oct 10, 2024
39 checks passed
@Caellian
Copy link
Collaborator

Thank you for your contribution @heavyjoost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report or bug fix PR display: x11 Issue related to X11 backend sources PR modifies project sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: conky not in fluxbox slit anymore
3 participants