Stop trying to access filesystems that are no longer in dynamically generated conky text #2023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/
has been updatedDescription
Dynamically updated conky texts that use "fs" variables can leave their entries in fs_stats after they have been removed from the text dynamically.
Instead of having update_fs_stats() call update_fs_stat() for all entries that have the "set" flag, just clear the "set" flag.
This will "remove" the current fs_stats entries (including in particular, filesystems that no longer appear in the conky text).
On the next update cycle, prepare_fs_stat() will call update_fs_stat() for anything that requires it, and will retain the logic that prevents it from updating the same fs multiple times.
Note: Depending on how well update frequencies line up, it is still possible to get stat errors but they won't continue forever.