[Test case] State update in subtree not being picked up #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Oh, thanks for the PR. That's a significant regression after introducing hooks! Fixing it asap 👍 |
|
Thanks @bryphe. I really appreciate it. The problem has been fixed. Sorry for that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Nested components in the tree don't seem to 'bubble up' their state changes into
flushPendingUpdates. This means that state changes work fine whenuseStateis the top-level element that we callflushPendingUpdateson, but if it is lower in the tree, the updates don't get picked up.This is possibly a misunderstanding on my end of the API, but it'd be helpful to see how to handle this case for revery revery-ui/revery#207