Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize downloading project deps and blobs from registry #58

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

kylewlacy
Copy link
Member

This PR improves how project downloads are handled from the registry:

  • Project dependencies are now downloaded in parallel. This might turn out to be problematic in the future because this download is recursive but has no semaphore to cap the total number of recursive downloads. This should suffice for a while (and I'm not confident enough in how to solve this in a way that wouldn't deadlock)
  • Project module blobs are now downloaded with the brioche_core::registry::fetch_blobs function, which will both download blobs in parallel and avoid downloading blobs that have been downloaded before

@kylewlacy kylewlacy merged commit 9bea426 into main Jun 9, 2024
5 checks passed
@kylewlacy kylewlacy deleted the parallelize-registry-project-downloads branch June 9, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant