Added hasEventListener check for addEventListener addition to fix iss… #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues with ontouchstart on Windows 10
This was referenced Nov 6, 2018
|
Since this uses jQuery, why not use jQuery for attaching events since it would handle this automatically? |
adr-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jul 8, 2019
Before this commit, on a device with a "pen" (e.g. Surface Pro, ...), it was not possible to sign a document on some browsers recently updated (e.g. Chrome, Firefox, ...) only Internet Explorer was working. Instead of drawing continuous lines only few dots appeared. For Chrome and Firefox we have to catch events with "addEventListener". For Edge we add touch-action property to convert touch events into click. Steps to reproduce: 1) Go to sales app 2) Then go to quotations (menu Sales) 3) Create a new quotation 4) Click on preview 5) Click on the "Accept" button at the end of the preview 6) Use the "pen" to draw the signature (BUG) We use a custom version of the jSignature lib (c.f. odoo/odoo@eddcb46), so we have to patch the file in the Odoo repo with a mix of some pull request found in the official repo and forks. Link: brinley/jSignature#109 brinley/jSignature#159 willowsystems/jSignature#96 opw-2029684
adr-odoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Jul 8, 2019
Before this commit, on a device with a "pen" (e.g. Surface Pro, ...), it was not possible to sign a document on some browsers recently updated (e.g. Chrome, Firefox, ...) only Internet Explorer was working. Instead of drawing continuous lines only few dots appeared. For Chrome and Firefox we have to catch events with "addEventListener". For Edge we add touch-action property to convert touch events into click. Steps to reproduce: 1) Go to sales app 2) Then go to quotations (menu Sales) 3) Create a new quotation 4) Click on preview 5) Click on the "Accept" button at the end of the preview 6) Use the "pen" to draw the signature (BUG) We use a custom version of the jSignature lib (c.f. eddcb46), so we have to patch the file in the Odoo repo with a mix of some pull request found in the official repo and forks. Link: brinley/jSignature#109 brinley/jSignature#159 willowsystems/jSignature#96 opw-2029684
l-schmitt
pushed a commit
to l-schmitt/web
that referenced
this pull request
May 17, 2021
…ng with Windows 10 (see : brinley/jSignature#159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ues with ontouchstart on Windows 10