Skip to content

Refactor ExternalConnection::sendStatus #30

@koudis

Description

@koudis

Function ExternalConnection::sendStatus consumes deviceState argument.

This argument does not make any sense because not in all cases it is used or it is overwritten!

Refactor the function in a manner that does not need deviceState argument (it is always used with value ExternalProtocol::Status_DeviceState_DISCONNECT, connect, ...).

Split function in two - for standard status and for disconnect status...? Or use explicit enum class and not reuse protobuf message state?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions