If its not a pcap, its a log #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskerr
changed the title
Merged
mason-fish
approved these changes
Apr 30, 2020
|
The symptoms in the console log looked like brimdata/super#613 but the artifacts for the failed run including any screen shots taken were removed on the rerun before I could get at them, so I can't be sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #687
Previously we were checking each file to see if was a pcap, zeek, json, or unknown type. Now we just check if any one of them is a pcap. If there is 1 pcap, we send it over the /pcaps/ endpoint, else /logs/.
This makes it simple and lets the backend do the rest of the auto detection. I've been even able to ingest a json and a zeek tsv at the same time now.