-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timezone Support #3139
Timezone Support #3139
Conversation
Summarizing an offline chat @jameskerr and I just had about my testing of this branch as of commit 6386dfb. Updating OutputChanging the Timezone setting is taking effect immediately in the Inspector view and the Detail pane, but the Table view isn't being updated until the query is re-run. Timezone In Rendered ValuesNow that we've got this pretty much working, it reveals the second-order topic of timestamp format. The way it's working in the branch at commit 6386dfb, there's currently no indicator of timezone/format in the rendered timestamp, so it's up to the user to remember that they've changed from the default in Settings, which is maybe ok but perhaps not ideal. We have the Time Format option in Settings that would allow the user to include timezone/offset if desired, but it feels like we could maybe improve further by changing our own default output formatting to include more explicit timezone info. There's multiple directions we could go, but here's a proposal (see brimdata/super#5221 for more Zed-layer detail on this topic). The way Zui has been up until recently has rendered the timestamps in UTC with the trailing "Z" exactly as they appear in ZSON output, e.g.,
I can execute a search that contains the local-time-with-offset in that format and it'll match a stored UTC value that represents the same instant in time. Notice the hour To make this easier, we'd move from the current time formatting library to one like https://github.com/samsonjs/strftime that supports these Finally, if we do what's proposed here, @jameskerr also pointed out that we should add some kind of grayed-out "placeholder" |
Fixes #1057