Native Node Fetch #3061
Merged
Native Node Fetch #3061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrz
approved these changes
May 2, 2024
Contributor
philrz
left a comment
philrz
left a comment
There was a problem hiding this comment.
@jameskerr did some Q&A with me on a brief Zoom and I'm now 👍 on these changes. I've also confirmed that once these changes are in place the fix to #3056 should be a one-liner. In the interest of addressing one thing at a time I'll put up a PR for that once this merges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update electron dependencies.
Drop node-fetch 🙌
Use node native fetch
It required I add the duplex: "half" option when sending a post body.