Skip to content

Update CONTRIBUTING with new Windows code signing info #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philrz merged 1 commit into from
Apr 29, 2024
Merged

Update CONTRIBUTING with new Windows code signing info #3055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions apps/zui/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,15 +199,13 @@ xcrun notarytool history --apple-id <apple-user-id> --password <app-specific-pas

### Windows Code Signing

To create signed Windows packages by hand, set the following environment
variables before running the `yarn` commands shown above.

```bash
export WIN_CSC_LINK=<base64-encoded-certificate>
export WIN_CSC_KEY_PASSWORD=<certificate-password>
```

Where `WIN_CSC_LINK` contains the base64-encoded code signing certificate and `WIN_CSC_KEY_PASSWORD` is the password used to decrypt it (details [here](https://www.electron.build/code-signing.html#windows)).
The changes in [ballot CSC-17](https://cabforum.org/2022/09/27/ballot-csc-17-subscriber-private-key-extension/)
from the [CA/B Forum](https://cabforum.org/) have made it such that GA Zui
releases on Windows are currently only signed using a cloud service.
PR [zui/3050](https://github.com/brimdata/zui/pull/3050) provides details of
how this is currently performed with [SSL.com's eSigner](https://www.ssl.com/esigner/).
If you successfully sign Zui with another service or sign manually and have
tips to share based on your experience, please [contact us](#questions).

## Licensing

Expand Down