Rename "release" target to avoid clash with "nx release" #2891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to build the GA Zui v1.4.0 release candidates it became apparent that the move from
nx15.8.7to16.10.0as part of #2834 caused an unexpected problem: Somewhere between those versions they introduced annx releasecommand that happened to clash with our use ofreleaseas a target in Zui'spackage.json. Once that was understood, the workaround of changing the target name as shown in this PR got me up & running again quickly.Since we already had
release-insidersI opted to call the new targetrelease-zuifor symmetry. Then I did similar treatment turning the adjacentpackagetarget intopackage-zuifor consistency, plus it insulates us against the possibility that the verbpackagegets claimed one day bynxas well. 😛