Add options argument to selectMulti for consistency with select#266
Open
paulftw wants to merge 1 commit intobrimdata:mainfrom
Open
Add options argument to selectMulti for consistency with select#266paulftw wants to merge 1 commit intobrimdata:mainfrom
paulftw wants to merge 1 commit intobrimdata:mainfrom
Conversation
select(...) supports optional flag to disable focus change but selectMulti(...) doesn't. This change makes the two methods consistent. It shouldn't break existing code. I copy-pasted the align option without understanding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
select(...) supports optional flag to disable focus change but selectMulti(...) doesn't. This change makes the two methods consistent.
It shouldn't break existing code.
I copy-pasted the align option without understanding it.
For reference: original select