Pin to specific versions of GitHub Actions Runners #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to generate a new Brimcap release, I noticed the generated Darwin one was for architecture
arm64with none foramd64as we've always generated in the pass. I could see this happened because in the Actions workflow we've been pointing to the-latestrevisions of the Runner types, but in the time since our last GA release, GitHub moved the-latestpointer forward tomacos-14which is based on Apple silicon whereasmacos-12andmacos-13are still Intel-based.I've avoided surprises like this in the Zui repo by pointing to explicit versions of the runners and only advancing them forward when those runner versions are deprecated or we have a specific motivation to advance the pointer and do the necessary testing at that time to ensure a smooth transition.
I imagine at some point we may want to take steps to produce separate
arm64artifacts for Brimcap like we've done for Zed and Zui. However, in the interest of getting our next releases out in a timely manner, I'd prefer to make that a separate/future exercise.I tested out these changes in a personal fork repo where you can see test release v1.7.1 that shows the problem and v1.8.1 that has the benefit of the fix.